sys/net/nanocoap: flush stale responses before sending request #21122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: network
benpicco
force-pushed
the
nanocoap_sock/flush
branch
from
b2ac6a3 to
5869554
Compare
benpicco
added
the
CI: ready for build
maribu
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The
nanocoap_sock_request_cb()function performs one CoAP request. Since it re-uses the socket between requests, stale responses can accumulate (especially in the non-confirmable case).Those are of no use - clear them out before sending a request so they don't fill up the sock's rx queue.
Testing procedure
Issues/PRs references