Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildsystem: keep subfolders of sources unique #21121

Merged
merged 2 commits into from
Jan 6, 2025
Merged

buildsystem: keep subfolders of sources unique #21121

merged 2 commits into from
Jan 6, 2025

Conversation

fabian18
Copy link
Contributor

@fabian18 fabian18 commented Jan 4, 2025

Contribution description

Fixes a tiny make warning when a subfolder has multiple source files.

RIOT/Makefile.base:120: target 'RIOT/examples/subfolders/bin/native/application_subfolders/folder/subfolder/' given more than once in the same rule

Testing procedure

Compile examples/subfolders without the fix now and you will get the warning.

Issues/PRs references

@fabian18 fabian18 added Area: build system Area: Build system Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer labels Jan 4, 2025
@github-actions github-actions bot added the Area: examples Area: Example Applications label Jan 4, 2025
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 5, 2025
@riot-ci
Copy link

riot-ci commented Jan 5, 2025

Murdock results

✔️ PASSED

b5101d9 Makefile.base: sort SUBDIRS for uniqueness

Success Failures Total Runtime
10248 0 10249 19m:14s

Artifacts

@mguetschow mguetschow self-requested a review January 6, 2025 08:48
mguetschow
mguetschow approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward enough, thanks for fixing!

@mguetschow mguetschow enabled auto-merge January 6, 2025 13:24
@mguetschow mguetschow added this pull request to the merge queue Jan 6, 2025
Merged via the queue into RIOT-OS:master with commit e62e388 Jan 6, 2025
29 checks passed
@fabian18 fabian18 deleted the pr/subdirs_unique branch January 11, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mguetschow mguetschow mguetschow approved these changes

Assignees
No one assigned
Labels
Area: build system Area: Build system Area: examples Area: Example Applications CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fabian18 @riot-ci @mguetschow @benpicco