Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards/nrf6310: Remove nRF6310 board from RIOT #20966

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

crasbe
Copy link
Contributor

@crasbe crasbe commented Nov 7, 2024

Contribution description

When working on the documentation of the nRF chips (#20592), I discovered that there is a board called "NRF6310" which supports the nRF6310 board (sometimes apparently called nRFgo?) and the Mommosoft BLE DEVKIT.N. Both are based on the nRF51822 chip.

I am not sure since when the nRFgo board has not been sold anymore, but there are no references at any of the typical distributors and the Nordic documentation experiences bitrot as well.
Mommosoft has not been around anymore since ~2019 and the most recent blog entries about the "BLE DEVKIT.N" are from around 2014.
The nRF51822 is still sold and supported by Nordic, however it was set to NRND in 2022 and the Product Change Notice says that the distributors should remove it once stock is depleted (https://mm.digikey.com/Volume0/opasdata/d220001/medias/docus/4884/PDN_049.pdf).

In conclusion the nRF6310 is pretty much unavailable and has been for a long time. References to it are found in many Makefile.ci files because of insufficient memory, therefore I would consider it to be obsolete for RIOT.
The nRF51822 as well as the nRF51 DKs should stay supported, as they are still available for purchase.

In case that opinion is not shared by the RIOT devs, this PR can just be closed (or postponed).

Edit: I know that usually boards are removed after a deprecation notice, but this board has been dead for so long, it might not be necessary.

Testing procedure

There shouldn't be any CI errors, otherwise I wouldn't know how to test it?

Issues/PRs references

This is related to #20592.

Some information I found about the boards (note that the link to Mommosoft goes to the Web Archive..):
https://doc.riot-os.org/group__boards__nrf6310.html
https://developer.nordicsemi.com/nRF51_SDK/nRF51_SDK_v4.x.x/doc/html/group__nrf51__setups.html#nrf51_setup_nrf6310
https://web.archive.org/web/20191031043659/http://www.mommosoft.com/blog/category/nrf51822/

@github-actions github-actions bot added Area: doc Area: Documentation Area: tests Area: tests and testing framework Area: build system Area: Build system Area: boards Area: Board ports Area: examples Area: Example Applications Area: Kconfig Area: Kconfig integration labels Nov 7, 2024
Copy link
Contributor

@Teufelchen1 Teufelchen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking out the trash 🗑️

I think I'll let another maintainer click on merge, just to be sure there is rough consensus.

@OlegHahm
Copy link
Member

Thanks for the clean up. I agree that we probably don't need the deprecation for this board. However, IIRC we did the procedure for much older boards already in the past. The next release is around the corner: should we announce it as deprecreated in 2025.01 and remove it in 2025.04 then?
(From my perspective, instant removal would be also fine.)

@crasbe
Copy link
Contributor Author

crasbe commented Dec 22, 2024

I think it would be the best solution to follow the procedure and mark it as deprecated in the upcoming release and remove it three months later. It's not that pressing IMO.

@miri64
Copy link
Member

miri64 commented Dec 23, 2024

Regardless the outcome, its removal commit should be documented in the LOSTANDFOUND.md

@MrKevinWeiss
Copy link
Contributor

ping :)

@MrKevinWeiss
Copy link
Contributor

or why not... It looks like all the comments have been addressed.

@MrKevinWeiss MrKevinWeiss enabled auto-merge January 8, 2025 09:48
auto-merge was automatically disabled January 22, 2025 15:10

Head branch was pushed to by a user without write access

@crasbe crasbe force-pushed the pr/remove_nrf6310 branch from 32be613 to fc39240 Compare January 22, 2025 15:10
@crasbe
Copy link
Contributor Author

crasbe commented Jan 22, 2025

I rebased this PR, there were merge conflicts after #21146 in the LOSTANDFOUND.md (nothing bad, but git didn't want to automatically merge it in the right order).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: boards Area: Board ports Area: build system Area: Build system Area: doc Area: Documentation Area: examples Area: Example Applications Area: Kconfig Area: Kconfig integration Area: tests Area: tests and testing framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants