drivers/slipdev: register with netdev

RIOT-OS · Jun 21, 2021 · c1eead9 · c1eead9
1 parent 9fbab8f
commit c1eead9
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 3 deletions.
diff --git a/drivers/include/net/netdev.h b/drivers/include/net/netdev.h
@@ -321,6 +321,7 @@ typedef enum {
     NETDEV_SX126X,
     NETDEV_CC2420,
     NETDEV_ETHOS,
+    NETDEV_SLIPDEV,
     /* add more if needed */
 } netdev_type_t;
 /** @} */

diff --git a/drivers/include/slipdev.h b/drivers/include/slipdev.h
@@ -105,8 +105,10 @@ typedef struct {
  *
  * @param[in] dev       device descriptor
  * @param[in] params    parameters for device initialization
+ * @param[in] index     index of @p params in a global parameter struct array.
+ *                      If initialized manually, pass a unique identifier instead.
  */
-void slipdev_setup(slipdev_t *dev, const slipdev_params_t *params);
+void slipdev_setup(slipdev_t *dev, const slipdev_params_t *params, uint8_t index);
 
 #ifdef __cplusplus
 }

diff --git a/drivers/slipdev/Makefile.dep b/drivers/slipdev/Makefile.dep
@@ -1,5 +1,6 @@
 USEMODULE += tsrb
 USEMODULE += eui_provider
+USEMODULE += netdev_register
 FEATURES_REQUIRED += periph_uart
 
 ifneq (,$(filter slipdev_stdio,$(USEMODULE)))

diff --git a/drivers/slipdev/slipdev.c b/drivers/slipdev/slipdev.c
@@ -252,12 +252,14 @@ static const netdev_driver_t slip_driver = {
     .set = netdev_set_notsup,
 };
 
-void slipdev_setup(slipdev_t *dev, const slipdev_params_t *params)
+void slipdev_setup(slipdev_t *dev, const slipdev_params_t *params, uint8_t index)
 {
     /* set device descriptor fields */
     dev->config = *params;
     dev->state = 0;
     dev->netdev.driver = &slip_driver;
+
+    netdev_register(&dev->netdev, NETDEV_SLIPDEV, index);
 }
 
 /** @} */
diff --git a/sys/net/gnrc/netif/init_devs/auto_init_slipdev.c b/sys/net/gnrc/netif/init_devs/auto_init_slipdev.c
@@ -48,7 +48,7 @@ void auto_init_slipdev(void)
 
         LOG_DEBUG("[auto_init_netif] initializing slip #%u\n", i);
 
-        slipdev_setup(&slipdevs[i], p);
+        slipdev_setup(&slipdevs[i], p, i);
         gnrc_netif_raw_create(&_netif[i], _slipdev_stacks[i], SLIPDEV_STACKSIZE,
                               SLIPDEV_PRIO, "slipdev",
                               (netdev_t *)&slipdevs[i]);