Improved Manager Icons #403
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on lucide.dev set, reworked and redesigned, complete with readme.
The column was supposed to represent VM type, but in a non-anonymous survey of core dev team, nobody could actually say what the icons mean, and they are also duplicated in the icon column and the template column.
marmarta
force-pushed
the
better_icons
branch
from
0633a34 to
69f2bb8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #403 +/- ##
==========================================
- Coverage 65.82% 65.67% -0.16%
==========================================
Files 18 18
Lines 3901 3892 -9
==========================================
- Hits 2568 2556 -12
- Misses 1333 1336 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Result of audit/icon design by Ura Design.
Remaining minor quibble: should we replace all standard ok/cancel icons? The default icon set is kind of an acquired taste.