fix: random circuit codes are non-CSS so return iscss(...) = false
instead of nothing
#463
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, @royess, The random_circuit codes are non-CSS so, I am wondering why the
iscss(::Type{...})
returnsnothing
. Shouldn't it returnfalse
? Hopefully, that is not a bad proposition?Could you explain if it was a typo or there is some reason behind it? Thanks! I agree with you that codes are non-CSS.
QuantumClifford.jl/src/ecc/codes/random_circuit.jl
Line 19 in 0d13791
Bravyi introduces a Mixed Integer Programming for CSS/QLDPC codes so his approach don't work for non-CSS codes. Hence, I want to exclude non-CSS codes so user does not end up calculating
distance
for non-CSS codes which throw solver error.iscss(::Type{...}) = false
would be helpful here because in a later PR, I want to do something like@Krastanov, Please help review this PR, Thank you!