feat: remove the double git sub-object in the helm request for values… #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pggb25
force-pushed
the
fix/change-helm-reques
branch
3 times, most recently
from
a25eecc to
711724c
Compare
mzottola
reviewed
Nov 21, 2023
| @@ -0,0 +1,26 @@ | |||
| type: object | |||
There was a problem hiding this comment.
Shouldn't it be nullable ?
There was a problem hiding this comment.
My understanding is that when used in a 'oneof,' it should not be nullable. Am I wrong?
pggb25
force-pushed
the
fix/change-helm-reques
branch
from
60db08d to
b880d7c
Compare
mzottola
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… part