-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use SamplerPubResult and update the use of DataBin #1708
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9369666142Details
💛 - Coveralls |
t-imamichi
changed the title
Use SamplerPubResult and mapping-like features of DataBin
Use SamplerPubResult and update the use of DataBin
May 30, 2024
kt474
approved these changes
May 30, 2024
Thank you for reviewing it. I'm not so familiar with the serialization part. So, I was relieved to see the review result. |
kt474
reviewed
May 30, 2024
t-imamichi
force-pushed
the
databin
branch
2 times, most recently
from
June 3, 2024 03:15
44aeec9
to
45942bc
Compare
I reverted two integration tests (test_sampler_v2.py and test_qctrl.py) until the server side is upgraded to qiskit 1.1 because the qiskit 1.0 returns |
t-imamichi
commented
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds codes to support the new features of PrimitivesV2 of Qiskit 1.1.
Details and comments
Fixes #1703
Fixes #1704