Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SamplerPubResult and update the use of DataBin #1708

Merged
merged 6 commits into from
Jun 4, 2024

Conversation

t-imamichi
Copy link
Member

@t-imamichi t-imamichi commented May 24, 2024

Summary

This PR adds codes to support the new features of PrimitivesV2 of Qiskit 1.1.

  • Use the mapping-like features of DataBin
  • Use the new DataBin constructor
  • Add serialization of SamplerPubResult

Details and comments

Fixes #1703
Fixes #1704

@t-imamichi t-imamichi requested a review from ihincks May 24, 2024 06:18
@coveralls
Copy link

coveralls commented May 24, 2024

Pull Request Test Coverage Report for Build 9369666142

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 82.27%

Totals Coverage Status
Change from base Build 9361903585: 0.005%
Covered Lines: 6009
Relevant Lines: 7304

💛 - Coveralls

@t-imamichi t-imamichi marked this pull request as ready for review May 30, 2024 02:25
@t-imamichi t-imamichi requested a review from kt474 May 30, 2024 02:29
@t-imamichi t-imamichi changed the title Use SamplerPubResult and mapping-like features of DataBin Use SamplerPubResult and update the use of DataBin May 30, 2024
@t-imamichi
Copy link
Member Author

Thank you for reviewing it. I'm not so familiar with the serialization part. So, I was relieved to see the review result.

@t-imamichi t-imamichi force-pushed the databin branch 2 times, most recently from 44aeec9 to 45942bc Compare June 3, 2024 03:15
@t-imamichi
Copy link
Member Author

I reverted two integration tests (test_sampler_v2.py and test_qctrl.py) until the server side is upgraded to qiskit 1.1 because the qiskit 1.0 returns PubResult (qiskit 1.1 returns SamplerPubResult).

@kt474 kt474 merged commit 972e7e4 into Qiskit:main Jun 4, 2024
20 checks passed
@t-imamichi t-imamichi deleted the databin branch June 5, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use new mapping features of DataBin Stop using make_data_bin when qiskit>=1.1
4 participants