Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure a DiceExecutionError is raised when Dice fails #26

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

caleb-johnson
Copy link
Collaborator

@caleb-johnson caleb-johnson commented Sep 24, 2024

The current logic only raises a DiceExecutionError when subprocess.run fails to execute. This isn't the right logic since subprocess.run will successfully execute even if the underlying process returns a non-zero return code. This PR checks the returncode explicitly and raises a DiceExecutionError alerting users to the failure of the Dice command line application and pointing them to the logfile.

@caleb-johnson caleb-johnson changed the title Ensure a DiceExceptionError is raised when Dice fails Ensure a DiceExecutionError is raised when Dice fails Sep 24, 2024
@caleb-johnson caleb-johnson merged commit 120dc46 into main Sep 25, 2024
5 checks passed
@caleb-johnson caleb-johnson deleted the dice-error branch September 25, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant