Ensure a DiceExecutionError is raised when Dice fails #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic only raises a
DiceExecutionError
whensubprocess.run
fails to execute. This isn't the right logic sincesubprocess.run
will successfully execute even if the underlying process returns a non-zero return code. This PR checks the returncode explicitly and raises aDiceExecutionError
alerting users to the failure of theDice
command line application and pointing them to the logfile.