Remove transpilations inside subexperiment generation #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8820682434Details
💛 - Coveralls |
caleb-johnson
changed the title
|
@garrison @ibrahim-shehzad I do think we should move away from DAGCircuit in our workflow until we decide to move entirely to it. This chart shows a pretty dramatic time cost as experiments scale up if we continue using transpiler passes to clean up resets. |
|
Something funny going on with the reno linter in CI for this PR hmmm |
Docs build is broken on main branch now as well. Submitted #559 to address |
…toolbox into no-transpiles
|
The chart was made using Tutorial 1 at 100 qubits on the All-Z observable. So 2 partitions, 1 observable. |
ibrahim-shehzad
previously approved these changes
Apr 23, 2024
garrison
reviewed
Apr 23, 2024
releasenotes/notes/subexperiment-gen-speedup-41a4e8679353d1d9.yaml
Outdated
Show resolved
Hide resolved
garrison
reviewed
Apr 23, 2024
garrison
reviewed
Apr 23, 2024
garrison
reviewed
Apr 23, 2024
garrison
reviewed
Apr 23, 2024
Co-authored-by: Jim Garrison <[email protected]>
Co-authored-by: Jim Garrison <[email protected]>
…knitting-toolbox into no-transpiles
…yaml Co-authored-by: Jim Garrison <[email protected]>
…knitting-toolbox into no-transpiles
garrison
reviewed
Apr 24, 2024
garrison
added a commit
that referenced
this pull request
Apr 24, 2024
This is due to python 3.8 no longer being available on the macos-latest CI runner. This also restores the ubuntu minimum version to 3.8 so that we test on 3.8 somewhere. #515 (comment) We might see intermittent CI failures again until #556 is merged (expected to be very soon).
…toolbox into no-transpiles
This was referenced Apr 25, 2024
Merged
4 tasks
garrison
added a commit
that referenced
this pull request
May 16, 2024
* Bump macos-latest python version This is due to python 3.8 no longer being available on the macos-latest CI runner. This also restores the ubuntu minimum version to 3.8 so that we test on 3.8 somewhere. #515 (comment) We might see intermittent CI failures again until #556 is merged (expected to be very soon). * Update test_latest_versions.yml use python 3.12 on macos, because then we will skip cplex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #529
Fixes #530
The copies used in the transpilation passes in subexperiment generation start becoming a bottleneck for larger experiments. This PR removes the transpilation in favor of modifying the QuantumCircuit objects directly and in-place. This is more in-line with the rest of our workflow and scales much better in that context.
