Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix follow-up action when a PR is closed #847

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

frankharkins
Copy link
Member

Summary

When a submission PR is closed, an action posts a comment with information for new ecosystem members. For example, #823 (comment).

The problem is that this comment is posted even when the PR is closed but wasn't merged. This PR fixes the workflow to only trigger when the PR is merged.

Copy link
Collaborator

@arnaucasau arnaucasau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@frankharkins frankharkins merged commit b7b2534 into main Dec 4, 2024
4 checks passed
@frankharkins frankharkins deleted the FH/fix-followup branch December 4, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants