Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

form validation #420

Closed
wants to merge 6 commits into from
Closed

form validation #420

wants to merge 6 commits into from

Conversation

dilroseR
Copy link
Contributor

Fixes #30

Describe the changes you've made

created form validation on email, phone no and pincode

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

NA

Additional context (OPTIONAL)

Add any other context or screenshots about the feature request here.

WhatsApp.Video.2021-07-24.at.4.46.46.PM.mp4

Checklist

  • I have mentioned related issue number in PR description.
  • I have added screenshots and related demo links of my changes..
  • The title of my pull request is a short description of the requested changes.
  • My code follows the code style of this project.
  • Open Source Program names(OPTIONAL: If you participated in any open-source program then please mention the program name here):- DevIncept Participant

@QAZIMAAZARSHAD
Copy link
Owner

There are few other fields also.

Share the website link so I can review your changes.

@dilroseR
Copy link
Contributor Author

There are few other fields also.

Share the website link so I can review your changes.

but the page is running locally right?
how to send the link?

@dilroseR
Copy link
Contributor Author

There are few other fields also.

Share the website link so I can review your changes.

can you specify which ones so I'll work on it

@QAZIMAAZARSHAD
Copy link
Owner

Check everything from top to bottom.

State, district, name, document uploaded, if selected other in disability, radio buttons, etc.

Are all the mandatory fields really mandatory?

Is the form gets submitted without non-mandatory inputs?

Check everything. And specific sweet alert for all inputs.

@dilroseR
Copy link
Contributor Author

Check everything from top to bottom.

State, district, name, document uploaded, if selected other in disability, radio buttons, etc.

Are all the mandatory fields really mandatory?

Is the form gets submitted without non-mandatory inputs?

Check everything. And specific sweet alert for all inputs.

ok , I'll check for all except non-mandatory

@QAZIMAAZARSHAD
Copy link
Owner

But if someone has filled non-mandatory fields, it should be proper.

@dilroseR
Copy link
Contributor Author

But if someone has filled non-mandatory fields, it should be proper.

alright, i'll check those as well

@nlok5923
Copy link
Contributor

There are few other fields also.
Share the website link so I can review your changes.

but the page is running locally right?
how to send the link?

you need to deploy your forked repo to any static deployment services like netlify and gh pages after that only we can verify the changes done by you.

@dilroseR
Copy link
Contributor Author

dilroseR commented Jul 26, 2021 •
edited
Loading

There are few other fields also.
Share the website link so I can review your changes.

but the page is running locally right?
how to send the link?

you need to deploy your forked repo to any static deployment services like netlify and gh pages after that only we can verify the changes done by you.

https://formvalidate12.netlify.app/
Can you check please what is the issue?

@QAZIMAAZARSHAD
Copy link
Owner

@dilroseR districts are not displaying in the drop-down list.

@dilroseR
Copy link
Contributor Author

@dilroseR districts are not displaying in the drop-down list.

it wasn't there before also

@dilroseR
Copy link
Contributor Author

@dilroseR districts are not displaying in the drop-down list.

should i do that as well?

@QAZIMAAZARSHAD
Copy link
Owner

@dilroseR districts are not displaying in the drop-down list.

it wasn't there before also

It was always present.
Chek again, compare with main website.
image

@dilroseR
Copy link
Contributor Author

@dilroseR districts are not displaying in the drop-down list.

it wasn't there before also

It was always present.
Chek again, compare with main website.
image

alright, i'll have a look
bdw did you check the specific alert and found out what's going wrong?
if yes then please let me know

@QAZIMAAZARSHAD
Copy link
Owner

If we select option 3A in the declaration section still it prompts to select option 3a or 3b.

Email and mobile are not mandatory still it prompts to enter an email address.

The form gets accepted without:
First-time voter or transfer radio button selection in the First section.
Without any selections in the mandatory specifications section.
Without any details other than pin in the address section.
Without city name, location and I am aware agreement in the declaration section.
And without Captcha.

@dilroseR
Copy link
Contributor Author

If we select option 3A in the declaration section still it prompts to select option 3a or 3b.

Email and mobile are not mandatory still it prompts to enter an email address.

The form gets accepted without:
First-time voter or transfer radio button selection in the First section.
Without any selections in the mandatory specifications section.
Without any details other than pin in the address section.
Without city name, location and I am aware agreement in the declaration section.
And without Captcha.

ok thanks i'll check

@dilroseR
Copy link
Contributor Author

i've sent you a video. kindly check that on slack

@QAZIMAAZARSHAD
Copy link
Owner

@dilroseR this problem is not occurring in the link you shared https://formvalidate12.netlify.app/ compare your new changes,

@dilroseR
Copy link
Contributor Author

@dilroseR this problem is not occurring in the link you shared https://formvalidate12.netlify.app/ compare your new changes,

@dilroseR this problem is not occurring in the link you shared https://formvalidate12.netlify.app/ compare your new changes,

are you talking about fetch and merge?

@QAZIMAAZARSHAD
Copy link
Owner

@dilroseR this problem is not occurring in the link you shared https://formvalidate12.netlify.app/ compare your new changes,

@dilroseR this problem is not occurring in the link you shared https://formvalidate12.netlify.app/ compare your new changes,

are you talking about fetch and merge?

No,

I mean the changes in this PR are not creating this problem, so check the problems in your recent updates in your local project.
you will find what is creating the issue.

@dilroseR
Copy link
Contributor Author

@dilroseR this problem is not occurring in the link you shared https://formvalidate12.netlify.app/ compare your new changes,

@dilroseR this problem is not occurring in the link you shared https://formvalidate12.netlify.app/ compare your new changes,

are you talking about fetch and merge?

No,

I mean the changes in this PR are not creating this problem, so check the problems in your recent updates in your local project.
you will find what is creating the issue.

ill try creating a new deployment link with the new changes then pls check

@dilroseR
Copy link
Contributor Author

https://blissful-roentgen-bf6449.netlify.app/
here is the new link

kanak22
kanak22 approved these changes Aug 3, 2021
View reviewed changes
Copy link

@kanak22 kanak22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QAZIMAAZARSHAD
Copy link
Owner

LGTM

No.
The form is getting submitted/reset without accepting all the details and with wrong inputs.
Not giving specific prompts for each wrong inputs.

@kanak22 help @dilroseR in resolving this issue.

@QAZIMAAZARSHAD QAZIMAAZARSHAD requested a review from kanak22 August 3, 2021 05:50
@kanak22
Copy link

kanak22 commented Aug 3, 2021

LGTM

No.
The form is getting submitted/reset without accepting all the details and with wrong inputs.
Not giving specific prompts for each wrong inputs.

@kanak22 help @dilroseR in resolving this issue.

Wrong inputs and specific prompts is what I noticed but the issue was only about prompting for the mandatory fields that info isn't filled yet

@QAZIMAAZARSHAD
Copy link
Owner

Even that condition is not fulfilled, the form gets reset without all inputs.

And the issue is to completely validate every input field with proper input, error messages, etc.

@dilroseR
Copy link
Contributor Author

dilroseR commented Aug 3, 2021

the form gets resetted whenever an alert appears. kindly help me on how to tackle this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlok5923 nlok5923 Awaiting requested review from nlok5923

@kanak22 kanak22 Awaiting requested review from kanak22

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Form validation for email, phone no., pin, etc. in application form
4 participants
@dilroseR @QAZIMAAZARSHAD @nlok5923 @kanak22