Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Improved #413

Closed
wants to merge 2 commits into from
Closed

Conversation

skpandey885
Copy link
Contributor

@skpandey885 skpandey885 commented Jul 22, 2021

#377

UI Improved and Responsiveness Improved!

@skpandey885
Copy link
Contributor Author

Its shows that my branch has some conflicts can you help me how to solve this conflict issue!
@QAZIMAAZARSHAD

@QAZIMAAZARSHAD
Copy link
Owner

Its shows that my branch has some conflicts can you help me how to solve this conflict issue!
@QAZIMAAZARSHAD

Fetch Upstream

@QAZIMAAZARSHAD
Copy link
Owner

Also share the deployment link so I can review your changes.

@skpandey885
Copy link
Contributor Author

Bhaiya the latest Changes Are Not reflecting In The Deployment link! That is the reason you were telling me that day to fetch upstream! i dont know why this is happening its just showing the chanhes it did 4 days ago and after that whatever changes im making its not reflecting there

@QAZIMAAZARSHAD
Copy link
Owner

Bhaiya the latest Changes Are Not reflecting In The Deployment link! That is the reason you were telling me that day to fetch upstream! i dont know why this is happening its just showing the chanhes it did 4 days ago and after that whatever changes im making its not reflecting there

It's because you are still a few commits behind.

Try to fetch upstream then see.
Screenshot (109)

@skpandey885
Copy link
Contributor Author

I did it multiple times

@QAZIMAAZARSHAD
Copy link
Owner

Never forget to share the deployment link.

@skpandey885
Copy link
Contributor Author

skpandey885 commented Jul 23, 2021

Never forget to share the deployment link.

Bhaiya I think I m having some issues! I deleted the environment link and I'm cloning it again and pushing it and will generate a fresh pr!

@QAZIMAAZARSHAD
Copy link
Owner

Never forget to share the deployment link.

Bhaiya I think I m having some issues! I deleted the environment link and I'm cloning it again and pushing it and will generate a fresh pr!

Fine.

I thought you are done.

@skpandey885
Copy link
Contributor Author

Never forget to share the deployment link.

Bhaiya I think I m having some issues! I deleted the environment link and I'm cloning it again and pushing it and will generate a fresh pr!

Fine.

I thought you are done.

I don't know why i am facing issues

@QAZIMAAZARSHAD
Copy link
Owner

Never forget to share the deployment link.

Bhaiya I think I m having some issues! I deleted the environment link and I'm cloning it again and pushing it and will generate a fresh pr!

Fine.
I thought you are done.

I don't know why i am facing issues

Start over again. This is the best way.

If we want to create something good we must prepare to throw our first work.

@QAZIMAAZARSHAD
Copy link
Owner

If you need any help @kanak22 will help you.

@QAZIMAAZARSHAD QAZIMAAZARSHAD requested a review from kanak22 July 23, 2021 16:07
@skpandey885
Copy link
Contributor Author

skpandey885 commented Jul 24, 2021

bhaiya! I am seeing these errors(red marks) from yesterday...check your repo of help.html file in vs code!

Screenshot 2021-07-24 at 12 24 07 PM

@skpandey885
Copy link
Contributor Author

Bhaiya you merge this pr! bcz this pr has all the changes I made! now again I have to do all steps !

@QAZIMAAZARSHAD QAZIMAAZARSHAD requested a review from nlok5923 July 24, 2021 07:01
Copy link
Contributor

@nlok5923 nlok5923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks PTAL !!

<h2><strong>Reach Us</strong></h2>
<br>

<h2 style="text-align: center; text-decoration: underline; font-family: 'Baloo Tammudu 2', cursive;">REACH US</h2>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skpandey885 you had used inline styling most of the place please convert it to class based styling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants