Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#332 #334

Closed
wants to merge 2 commits into from
Closed

#332 #334

wants to merge 2 commits into from

Conversation

shanksandbox
Copy link
Contributor

Flip Logo Corrected

Issue Number #332

Flip Logo Corrected
@shanksandbox
Copy link
Contributor Author

Do you confirm sir?!

@shanksandbox
Copy link
Contributor Author

16255205599334971349832210969956

@QAZIMAAZARSHAD
Copy link
Owner

Do you confirm sir?!

Is this the change shown in the image you have done?

@QAZIMAAZARSHAD
Copy link
Owner

Logo in all pages should be like this https://qazimaazarshad.github.io/Voters-Registration-Portal/help.html.

@shanksandbox
Copy link
Contributor Author

The logo in help page is flipping when hovered on.

@QAZIMAAZARSHAD
Copy link
Owner

The logo in help page is flipping when hovered on.

Yesss, but not in other pages that's the issue.

Make all pages logo similar to help page.

@shanksandbox
Copy link
Contributor Author

The flip logo is working fine in all pages.
Can u share the snap for issue in Base Repo

@QAZIMAAZARSHAD
Copy link
Owner

Screenshot (22)
Screenshot (24)

The red circle indicates the wrong output on hover.
The blue circle indicates the correct output on hover.

@QAZIMAAZARSHAD
Copy link
Owner

@stellashank do only necessary changes.

The problem is in style.css.

Make new PR.

@shanksandbox
Copy link
Contributor Author

#30 Validation for Password Email Phone no. done in second commit.
can u confirm sir?

@QAZIMAAZARSHAD
Copy link
Owner

#30 Validation for Password Email Phone no. done in second commit.
can u confirm sir?

@stellashank make separate PR's for separate issues and mention related issue numbers.

@QAZIMAAZARSHAD
Copy link
Owner

And issue number 30 is for the main form not sign-up page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants