Add properties support [WIP] #447
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works good. Only issue I have is to add an additional slab block, you have to click on a placed block (slab). I'm sure the client sends the position along the block the player clicked, so you can do a comparison with that. Also, If you use the offset math function in WorldPosition, you can check if the block is a slab and respond accordingly. |
|
@Bafran any progress ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue #197 - Slabs don't stack
Add support for block properties. Uses a hashmap on server startup to build a property mapping.
Testing
Please follow our Coding Guidelines