Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added esgf-cookbook to the gallery #219

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Added esgf-cookbook to the gallery #219

merged 1 commit into from
Jan 8, 2025

Conversation

clyne
Copy link
Contributor

@clyne clyne commented Jan 7, 2025

No description provided.

@clyne clyne requested a review from a team as a code owner January 7, 2025 19:32
@clyne clyne requested review from dcamron and r-ford and removed request for a team January 7, 2025 19:32
Copy link

github-actions bot commented Jan 7, 2025

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 4f22169
✅ Deployment Preview URL: https://ProjectPythia.github.io/cookbook-gallery/_preview/219

@clyne clyne requested review from erogluorhan and brian-rose and removed request for dcamron and r-ford January 7, 2025 19:32
Copy link
Member

@erogluorhan erogluorhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; thanks for adding this!

@brian-rose
Copy link
Member

Closes #218

@brian-rose
Copy link
Member

It looks like there's a missing logo in the preview. I will investigate.

@brian-rose
Copy link
Member

It looks like there's a missing logo in the preview. I will investigate.

The path to the logo image in the _gallery_info.yml file for this cookbook is given as a URL but our gallery generation script doesn't support that. Our script expects a relative path from the source repo root.

I'll open a PR on the ESGF Cookbook repo to fix that.

@clyne
Copy link
Contributor Author

clyne commented Jan 8, 2025

It looks like there's a missing logo in the preview. I will investigate.

The path to the logo image in the _gallery_info.yml file for this cookbook is given as a URL but our gallery generation script doesn't support that. Our script expects a relative path from the source repo root.

I'll open a PR on the ESGF Cookbook repo to fix that.

Thanks, @brian-rose . In the interim can we approve and merge this?

@clyne
Copy link
Contributor Author

clyne commented Jan 8, 2025

Whoops. I see the fix as been submitted to the cookbook itself. never mind

@mgrover1
Copy link
Contributor

mgrover1 commented Jan 8, 2025

Thanks for the fix @brian-rose - I just approved + merged, should be good to go 🎉

@brian-rose
Copy link
Member

Closing and reopening to trigger a new preview, just to make sure the logo is fixed.

@brian-rose brian-rose closed this Jan 8, 2025
@brian-rose brian-rose reopened this Jan 8, 2025
github-actions bot pushed a commit that referenced this pull request Jan 8, 2025
@brian-rose
Copy link
Member

All good, merging now.

@brian-rose brian-rose merged commit 3bb7d25 into main Jan 8, 2025
5 checks passed
@brian-rose brian-rose deleted the esgf-cookbook branch January 8, 2025 16:54
github-actions bot pushed a commit that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants