-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UPD] GAS optimisations / DRY #1268
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1268 +/- ##
=======================================
Coverage 99.77% 99.77%
=======================================
Files 22 22
Lines 1363 1363
Branches 220 220
=======================================
Hits 1360 1360
Misses 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment. |
@0age Can you trigger the workflow again? |
@0age Is this up for review? Is there anything I need to do? |
i don't see an option to trigger workflow, can you push a fresh commit to see if it shows up? thanks for the PR! |
Looks like I have a conflict anyhow so let me resolve that!.. It only triggered on my first commit and @0age triggered the last time.. |
I fixed the merge conflicts but it still does not trigger automatically :) |
This PR has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment. |
Gas optimisations and DRY standards.
Remove length from loops
Remove declarations out of loops (except
contracts/helpers/TransferHelper.sol
- handled here #1261 )Abstract duplicate code into DRY functions
Better naming for 'items'