Skip to content

Commit

Permalink
address more comments
Browse files Browse the repository at this point in the history
  • Loading branch information
stephankmin committed Nov 1, 2023
1 parent c49141c commit e39736a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion script/DeployAndRedeemTrait.s.sol
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ contract DeployAndRedeemTrait is Script, Test {
TraitRedemption[] memory traitRedemptions = new TraitRedemption[](1);

// trait key is "hasRedeemed"
bytes32 traitKey = bytes32(bytes(string("hasRedeemed")));
bytes32 traitKey = bytes32("hasRedeemed");

// previous trait value (`substandardValue`) should be 0
bytes32 substandardValue = bytes32(uint256(0));
Expand Down
2 changes: 1 addition & 1 deletion test/ERC7498-DynamicTraits.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ contract ERC7498_DynamicTraits is BaseRedeemablesTest {
TraitRedemption[] memory traitRedemptions = new TraitRedemption[](1);

// trait key is "hasRedeemed"
bytes32 traitKey = bytes32(bytes(string("hasRedeemed")));
bytes32 traitKey = bytes32("hasRedeemed");

// previous trait value (`substandardValue`) should be 0
// new trait value should be 1
Expand Down

0 comments on commit e39736a

Please sign in to comment.