Protocol address fix (#863)

* fix: protocol address condition fix (#861) --------- Co-authored-by: Pravin kumar <[email protected]>
ProjectOpenSea · Mar 6, 2023 · df72323 · df72323
1 parent 099605b
commit df72323
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 34 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "opensea-js",
-  "version": "4.0.17",
+  "version": "4.0.18",
   "description": "JavaScript SDK for the OpenSea marketplace. Let users buy or sell crypto collectibles and other cryptogoods, all on your own site!",
   "license": "MIT",
   "author": "OpenSea Developers",

diff --git a/src/sdk.ts b/src/sdk.ts
@@ -134,6 +134,7 @@ import {
   BigNumberInput,
   getAddressAfterRemappingSharedStorefrontAddressToLazyMintAdapterAddress,
   feesToBasisPoints,
+  isValidProtocol,
 } from "./utils/utils";
 
 export class OpenSeaSDK {
@@ -975,12 +976,7 @@ export class OpenSeaSDK {
     accountAddress: string;
     domain?: string;
   }): Promise<string> {
-    if (
-      !(
-        order.protocolAddress in
-        [CROSS_CHAIN_SEAPORT_ADDRESS, CROSS_CHAIN_SEAPORT_V1_4_ADDRESS]
-      )
-    ) {
+    if (!isValidProtocol(order.protocolAddress)) {
       throw new Error("Unsupported protocol");
     }
 
@@ -1039,12 +1035,7 @@ export class OpenSeaSDK {
     recipientAddress?: string;
     domain?: string;
   }): Promise<string> {
-    if (
-      !(
-        order.protocolAddress in
-        [CROSS_CHAIN_SEAPORT_ADDRESS, CROSS_CHAIN_SEAPORT_V1_4_ADDRESS]
-      )
-    ) {
+    if (!isValidProtocol(order.protocolAddress)) {
       throw new Error("Unsupported protocol");
     }
 
@@ -1182,12 +1173,7 @@ export class OpenSeaSDK {
     accountAddress: string;
     domain?: string;
   }) {
-    if (
-      !(
-        order.protocolAddress in
-        [CROSS_CHAIN_SEAPORT_ADDRESS, CROSS_CHAIN_SEAPORT_V1_4_ADDRESS]
-      )
-    ) {
+    if (!isValidProtocol(order.protocolAddress)) {
       throw new Error("Unsupported protocol");
     }
 
@@ -1759,12 +1745,7 @@ export class OpenSeaSDK {
     order: OrderV2;
     accountAddress: string;
   }): Promise<boolean> {
-    if (
-      !(
-        order.protocolAddress in
-        [CROSS_CHAIN_SEAPORT_ADDRESS, CROSS_CHAIN_SEAPORT_V1_4_ADDRESS]
-      )
-    ) {
+    if (!isValidProtocol(order.protocolAddress)) {
       throw new Error("Unsupported protocol");
     }
 
@@ -2794,14 +2775,7 @@ export class OpenSeaSDK {
    * @returns Transaction hash of the approval transaction
    */
   public async approveOrder(order: OrderV2, domain?: string) {
-    if (
-      !(
-        order.protocolAddress.toLowerCase() ===
-          CROSS_CHAIN_SEAPORT_ADDRESS.toLowerCase() ||
-        order.protocolAddress.toLowerCase() ===
-          CROSS_CHAIN_SEAPORT_V1_4_ADDRESS.toLowerCase()
-      )
-    ) {
+    if (!isValidProtocol(order.protocolAddress)) {
       throw new Error("Unsupported protocol");
     }
 

diff --git a/src/utils/utils.ts b/src/utils/utils.ts
@@ -1,4 +1,8 @@
-import { ItemType } from "@opensea/seaport-js/lib/constants";
+import {
+  CROSS_CHAIN_SEAPORT_ADDRESS,
+  CROSS_CHAIN_SEAPORT_V1_4_ADDRESS,
+  ItemType,
+} from "@opensea/seaport-js/lib/constants";
 import BigNumber from "bignumber.js";
 import { AbiType, CallData, TxData } from "ethereum-types";
 import * as ethUtil from "ethereumjs-util";
@@ -1131,3 +1135,16 @@ export const feesToBasisPoints = (
     0
   );
 };
+
+/**
+ * checks protocol address
+ * @param protocolAddress a protocol address
+ */
+export const isValidProtocol = (protocolAddress: string): boolean => {
+  const checkSumAddress = Web3.utils.toChecksumAddress(protocolAddress);
+  const validProtocolAddresses = [
+    CROSS_CHAIN_SEAPORT_ADDRESS,
+    CROSS_CHAIN_SEAPORT_V1_4_ADDRESS,
+  ];
+  return validProtocolAddresses.includes(checkSumAddress);
+};