Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Portuguese localizations #283

Merged
merged 2 commits into from
Dec 4, 2019
Merged

Update Portuguese localizations #283

merged 2 commits into from
Dec 4, 2019

Conversation

1ec5
Copy link
Member

@1ec5 1ec5 commented Apr 2, 2019

Synchronized the Portuguese localizations with Transifex. Thanks to @xendez and @jppcel for the updates.

/cc @danpaz

@1ec5 1ec5 self-assigned this Apr 2, 2019
@1ec5 1ec5 requested a review from danpaz April 2, 2019 17:59
@1ec5 1ec5 force-pushed the 1ec5-pt-2019-04-02 branch from f614333 to 241fffb Compare July 23, 2019 20:50
@1ec5 1ec5 force-pushed the 1ec5-pt-2019-04-02 branch from 241fffb to 8122ea4 Compare December 3, 2019 21:37
@1ec5 1ec5 mentioned this pull request Dec 4, 2019
Open
6 tasks
1ec5
1ec5 commented Dec 4, 2019
View reviewed changes
languages/translations/pt-BR.json
@@ -112,7 +112,7 @@
"upcoming": "Você vai chegar ao seu {nth} destino, em frente",
"short": "Você chegou",
"short-upcoming": "Você vai chegar",
"named": "Você chegou a (ao) {waypoint_name}, logo em frente"
"named": "Você chegou a {waypoint_name}, logo em frente"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I backed out this change in favor of a grammar system that can automatically add a (mostly) appropriate article contraction: #294. Please have a look @jppcel @yuryleb.

@1ec5
Copy link
Member Author

1ec5 commented Dec 4, 2019

This PR is ready for a final review, now that the grammatical question has been split off as #294.

@1ec5 1ec5 requested a review from danpaz December 4, 2019 18:53
danpaz
danpaz approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@danpaz danpaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you skipped translating the junction_name strings in portugese intentionally right? Otherwise LGTM.

@danpaz
Copy link
Contributor

danpaz commented Dec 4, 2019

Ah and reminder to update the changelog 📝

@1ec5 1ec5 force-pushed the 1ec5-pt-2019-04-02 branch from 5971e65 to b641a6b Compare December 4, 2019 19:02
@1ec5
Copy link
Member Author

1ec5 commented Dec 4, 2019

Whoops, forgot to interactively commit those changes. I’ve limited the changes to just the changes in Transifex. I added a blurb to the changelog since the affected strings are fairly prominent.

@1ec5 1ec5 merged commit 4fdb227 into master Dec 4, 2019
danpaz added a commit that referenced this pull request Dec 4, 2019
@danpaz
v0.14.0
069469b 
- Update Japanese localization, add named intersections. [#290](#290)
- Corrected various Portuguese translations. [#283](#283)
@danpaz danpaz mentioned this pull request Dec 4, 2019
Merged
@1ec5 1ec5 deleted the 1ec5-pt-2019-04-02 branch December 10, 2019 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuryleb yuryleb yuryleb left review comments

@jppcel jppcel jppcel left review comments

@danpaz danpaz danpaz approved these changes

Assignees

@1ec5 1ec5

Labels
translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@1ec5 @danpaz @jppcel @yuryleb