Implementing data validation #209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove main() and make n_queens a header file * move functions inside NQueensSolver class
and drop ".test" from tests
and update unit test
* add commands for installing CMake 3.10 * update build command
and add build entry in CMakeLists
* call solve() in the constructor to guarantee that the puzzle has been solved when calling any public method * show_solution -> print_solution
…#200) Importing the `std` namespace can lead to namespace pollution. This commit replaces those namespace directives with more specific ones, such as `using std::cin`.
Refactor greatest common denominator algorithm to use a header file. Add test cases as .cpp file to test. Also fix an error in greatest common denominator function that prevented the accurate calculation of negative arguments. Update README. * Migrate extended Euclidean to header, unit tests Removes old .cpp file for the extended Euclidean algorithm and adds unit tests. Also updates README. * Fix accidental addition of old denominator files
It looks like there may be issues with how you pulled the repo and then merged back in. There are conflicts between those commits which is why you can't merge your work back in. Which files did you actually mean to modify? And did you follow the directions here? |
|
This issue has been automatically marked as inactive because it has not had recent activity. It will be closed in 15 days if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added utility methods that do the following:
This PR closes issue #99