use prismarine-world

[rom1504]

No description provided.

[rom1504]

next steps of this plan :

• move find block to somewhere outside of mineflayer, so it can be used with any prismarine-world (either its own package, either directly in prismarine-world)
• make the viewer use prismarine-world only
• create an example showing how to save a mineflayer world to anvil (rendered trivial by using prismarine-world)

[rom1504]

Then (from @Karang )

• A way to store block entities https://github.com/PrismarineJS/mineflayer/blob/master/lib/plugins/blocks.js#L27 it would make sense to have it directly in prismarine-chunks similar to what mojang do (would simplify things for storing chunks), but that could go first in prismarine-world
• Some events, world is already an EventEmitter, but no events are emitted (blockUpdate, chunkColumnLoad/Unload, etc..) eventually those events could be removed or proxyed in mineflayer
• entities ? If we want to be able to use only pworld in pviewer, we also need the world to emit entity related events: https://github.com/PrismarineJS/prismarine-viewer/blob/master/lib/mineflayer.js#L82

(this can be done in other PRs, I may copy this content to an issue later)

[rom1504]

PrismarineJS/prismarine-world#42 is required so tests won't fail because we don't have anvil support for all versions

[Karang]

we should be able to use directly:

const block = bot.world.sync.getBlock(absolutePoint)

also, I think that pworld should do the line:

block.position = loc.floored

[rom1504]

yeah totally, I was mainly trying to make as little change as possible while making it works
I'll clean this up

[rom1504]

Yeah didn't have time to continue this. I think it's quite doable, must be just a small detail that isn't right

[rom1504]

needed to merge this:

• fix tests
• update viewer (_columns is gone)
• reviews

[rom1504]

After the followup on this, bot.blockAt will be deprecated, bot.world.getBlock should be used. (that'll be when everything of the world is ported to prismarine-world)

[rom1504]

Ok fixed the tests
Could you review @Karang ?
The idea here is to introduce prismarine-world.
To fully take advantage of it, I put the follow up at #334 (comment)

[Karang]

Looks good, left 2 minor comments.