Separate Python code from specfem2d.cpp #433
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsawade
approved these changes
Jan 24, 2025
Comment on lines
+24
to
+28
|
|
||
| void execute( | ||
| const YAML::Node ¶meter_dict, const YAML::Node &default_dict, | ||
| std::vector<std::shared_ptr<specfem::periodic_tasks::periodic_task> > tasks, | ||
| specfem::MPI::MPI *mpi); |
There was a problem hiding this comment.
should this maybe be specfem.hpp? since it'll contain all the headers required for running a simulation?
| @@ -0,0 +1,105 @@ | |||
| #include "execute.hpp" | |||
There was a problem hiding this comment.
Then this would call the specfem header
|
|
||
| return message.str(); | ||
| } | ||
| #include "execute.hpp" | ||
|
|
||
| boost::program_options::options_description define_args() { | ||
| namespace po = boost::program_options; |
There was a problem hiding this comment.
This file could keep its name still
|
|
||
| target_link_libraries( | ||
| specfem2d | ||
| execute |
There was a problem hiding this comment.
then the executable specfem2d
There was a problem hiding this comment.
specfem2d.cpp contains main(), which is not needed by Python. execute.cpp contains only the execute() function.
There was a problem hiding this comment.
I think there is text missing in this comment (did it from vscode). What I meant is: then the specfem2d executable and python/core are dependent on specfem.h/cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Closes #432