Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for multiple sources #427

Open
wants to merge 11 commits into
base: issue-228-anisotropy
Choose a base branch
from
Open

Allow for multiple sources #427

wants to merge 11 commits into from

Conversation

lsawade
Copy link
Collaborator

@lsawade lsawade commented Jan 23, 2025 •
edited
Loading

Description

See #420

Issue Number

Closes #421

Checklist

Please make sure to check developer documentation on specfem docs.

  • I ran the code through pre-commit to check style
  • My code passes all the integration tests
  • I have added sufficient unittests to test my changes
  • I have added/updated documentation for the changes I am proposing
  • I have updated CMakeLists to ensure my code builds
  • My code builds across all platforms

@icui
Copy link
Collaborator

icui commented Jan 24, 2025

LGTM

@lsawade
Copy link
Collaborator Author

lsawade commented Jan 24, 2025

@Rohit-Kakodkar Some new changes through
fa6cef6
7c9da2c

To make sources fully independent of nspec.

@lsawade lsawade mentioned this pull request Jan 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icui icui icui approved these changes

@Rohit-Kakodkar Rohit-Kakodkar Awaiting requested review from Rohit-Kakodkar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lsawade @icui