Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement anisotropic properties_container. #269

Merged
merged 8 commits into from
Dec 10, 2024
Merged

Conversation

icui
Copy link
Collaborator

@icui icui commented Dec 10, 2024

Description

Implement anisotropic properties_container.

Issue Number

Closes #251

Checklist

Please make sure to check developer documentation on specfem docs.

[] I ran the code through pre-commit to check style
[] My code passes all the integration tests
[] I have added sufficient unittests to test my changes
[] I have added/updated documentation for the changes I am proposing
[] I have updated CMakeLists to ensure my code builds
[] My code builds across all platforms

@Rohit-Kakodkar
Copy link
Collaborator

We will also need to update src/compute_properties.cpp to add elastic isotropic properties during construction of specfem::compute::properties

Copy link
Collaborator

@lsawade lsawade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsawade
Copy link
Collaborator

lsawade commented Dec 10, 2024

We will also need to update src/compute_properties.cpp to add elastic isotropic properties during construction of specfem::compute::properties

Are you doing this as part of this issue, @icui ?
Maybe open another one or mention this in #228.

@icui
Copy link
Collaborator Author

icui commented Dec 10, 2024

We will also need to update src/compute_properties.cpp to add elastic isotropic properties during construction of specfem::compute::properties

Are you doing this as part of this issue, @icui ? Maybe open another one or mention this in #228.

I'm working on it.

@icui
Copy link
Collaborator Author

icui commented Dec 10, 2024

We will also need to update src/compute_properties.cpp to add elastic isotropic properties during construction of specfem::compute::properties

Are you doing this as part of this issue, @icui ? Maybe open another one or mention this in #228.

Now updated. I've merged branch issue-250 in order to compile.

Copy link
Collaborator

@Rohit-Kakodkar Rohit-Kakodkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@icui icui merged commit a802c2f into issue-228-anisotropy Dec 10, 2024
2 of 3 checks passed
@icui icui deleted the issue-251 branch December 10, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants