Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update widget_toolkit_otp and example project #125

Merged
merged 5 commits into from
Sep 5, 2024

Conversation

DDavidPrime
Copy link
Member

@DDavidPrime DDavidPrime commented Sep 4, 2024

Overview

One in a series of PRs to cover the widget_toolkit ecosystem update to support latest version of packages.

Checklist

Implementation

  • Implementation matches ticket acceptance criteria and technical notes
  • Manually tested against Acceptance Criteria
  • UI checked on Android / iOS

Stability

  • Checked if changes affect any features and verified affected features work as expected
    - [ ] Added unit tests for new code and verified existing tests work as expected

Code quality

  • Updated CHANGELOG.md, README.md and package versions in pubspec.yaml
  • Dependencies are updated to latest versions or new tickets are created if there are breaking changes or deprecations
    - [ ] If an unrelated part of the codebase needs to be updated or refactored, create tickets with proposed changes

Copy link
Contributor

@GoranPrime GoranPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the breaking change with pinput and smart_auth, I think it's worth testing this functionality more thoroughly, when we're done with the updates

@DDavidPrime DDavidPrime merged commit 9ff447c into develop Sep 5, 2024
5 checks passed
@DDavidPrime DDavidPrime deleted the feat/update-widget_toolkit_otp branch September 5, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants