Implement new SmallButton type widget #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanevPrime
reviewed
Aug 6, 2024
packages/widget_toolkit/lib/src/lib_ui_components/buttons/small_button.dart
Show resolved
Hide resolved
StanevPrime
reviewed
Aug 6, 2024
packages/widget_toolkit/lib/src/lib_ui_components/buttons/small_button.dart
Outdated
Show resolved
Hide resolved
StanevPrime
requested changes
Aug 9, 2024
StanevPrime
requested changes
Aug 9, 2024
packages/widget_toolkit/lib/src/lib_ui_components/buttons/small_button.dart
Outdated
Show resolved
Hide resolved
StanevPrime
requested changes
Aug 9, 2024
packages/widget_toolkit/lib/src/lib_ui_components/buttons/small_button.dart
Outdated
Show resolved
Hide resolved
StanevPrime
requested changes
Aug 9, 2024
packages/widget_toolkit/lib/src/lib_ui_components/buttons/small_button.dart
Outdated
Show resolved
Hide resolved
StanevPrime
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements a new
SmallButtontype,SmallButtonType.icon, for displaying Icon buttonsChecklist
Implementation
Stability
Added unit tests for new code and verified existing tests work as expectedCode quality
CHANGELOG.md,README.mdand package versions inpubspec.yamlDependencies are updated to latest versions or new tickets are created if there are breaking changes or deprecations