Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loading indicator alignment on SmallButton widget #115

Merged
merged 8 commits into from
Jul 31, 2024
Merged

Fix loading indicator alignment on SmallButton widget #115

merged 8 commits into from
Jul 31, 2024

Conversation

JvnSlv
Copy link
Contributor

@JvnSlv JvnSlv commented Jul 29, 2024 •
edited by StanevPrime
Loading

Overview

Closes: #114

This PR fixes the loading state of SmallButton widget's loading indicator alignment

Checklist

Implementation

  • Implementation matches ticket acceptance criteria and technical notes
  • Manually tested against Acceptance Criteria
  • UI checked in Light / Dark mode

Stability

  • Checked if changes affect any features and verified affected features work as expected
  • Added unit tests for new code and verified existing tests work as expected

Code quality

  • Updated CHANGELOG.md, README.md and package versions in pubspec.yaml
  • Dependencies are updated to latest versions or new tickets are created if there are breaking changes or deprecations
  • If an unrelated part of the codebase needs to be updated or refactored, create tickets with proposed changes

@JvnSlv JvnSlv added the bug Something isn't working label Jul 29, 2024
@JvnSlv JvnSlv requested a review from RomanovaPrime July 29, 2024 18:13
@JvnSlv JvnSlv self-assigned this Jul 29, 2024
@JvnSlv JvnSlv requested a review from StanevPrime July 30, 2024 09:04
@JvnSlv JvnSlv merged commit 173b5c4 into develop Jul 31, 2024
5 checks passed
@DDavidPrime DDavidPrime deleted the fix/small-button-loading-indicator branch September 2, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomanovaPrime RomanovaPrime RomanovaPrime approved these changes

@StanevPrime StanevPrime StanevPrime approved these changes

Assignees

@DDavidPrime DDavidPrime

@JvnSlv JvnSlv

Labels
bug Something isn't working
Projects
widget_toolkit
Status: Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loading Indicator Misalignment in SmallButton Widget
4 participants
@JvnSlv @StanevPrime @RomanovaPrime @DDavidPrime