Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logout button improvements - Fix padding on loading. Hide the button … #977

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

RomanovaPrime
Copy link
Contributor

…after logout. Optimise the business logic

Overview

Closes: #970

< Pull Request Description >

Checklist

Implementation

  • Implementation matches ticket acceptance criteria and technical notes
  • Manually tested against Acceptance Criteria
  • UI checked in Light / Dark mode

Stability

  • Checked if changes affect any features and verified affected features work as expected

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.66%. Comparing base (69193bc) to head (e5a8e1a).
Report is 13 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #977   +/-   ##
========================================
  Coverage    95.66%   95.66%           
========================================
  Files          121      121           
  Lines         2632     2632           
========================================
  Hits          2518     2518           
  Misses         114      114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need to move the logout button ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was an issue in the mocking one of states. I have fixed it and reupload tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Logout loading indicator padding
3 participants