Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document geoiplookup and expose GeoIPQueryAttribute to Lua #14972

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BozhanL
Copy link
Contributor

@BozhanL BozhanL commented Dec 14, 2024

Short description

Document geoiplookup function (introduced in #6171). Closes #8597
Expose enum GeoIPQueryAttribute from geoipinterface.hh to Lua.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12326519530

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 42 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.007%) to 64.773%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/lua-record.cc 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pdns/packethandler.cc 1 72.35%
pdns/backends/gsql/gsqlbackend.hh 1 97.71%
pdns/recursordist/aggressive_nsec.cc 2 66.17%
pdns/tcpiohandler.cc 2 68.18%
modules/lmdbbackend/lmdbbackend.cc 2 73.49%
pdns/recursordist/test-syncres_cc2.cc 3 88.91%
pdns/tsigverifier.cc 3 77.22%
modules/gpgsqlbackend/spgsql.cc 3 67.94%
pdns/dnsdistdist/dnsdist-tcp.cc 8 75.74%
pdns/recursordist/ext/luawrapper/include/LuaContext.hpp 8 14.19%
Totals Coverage Status
Change from base Build 12316427950: -0.007%
Covered Lines: 125910
Relevant Lines: 163532

💛 - Coveralls

@Habbie Habbie added this to the auth-5 milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc: don't have use lua record geoiplookup example
4 participants