-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auth LUA createForward6: on parse problem, return :: instead of SERVFAIL #14630
base: master
Are you sure you want to change the base?
Conversation
this mirrors how we handle the v4 case closes PowerDNS#14629
Pull Request Test Coverage Report for Build 10737967328Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
@@ -966,21 +966,22 @@ static void setupLuaRecords(LuaContext& lua) // NOLINT(readability-function-cogn | |||
lua.writeFunction("createForward6", []() { | |||
DNSName rel=s_lua_record_ctx->qname.makeRelative(s_lua_record_ctx->zone); | |||
auto parts = rel.getRawLabels(); | |||
string address = "::"; | |||
|
|||
if(parts.size()==8) { | |||
string tot; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to make the code simpler to read, it would be worth getting rid of that tot
variable and operate on address
directly, after clearing it (address.clear()
).
Short description
this mirrors how we handle the v4 case
closes #14629
Checklist
I have: