misc: Use boost::ends_with() in isCanonical instead of open-coding

boost:ends_with(qname, ".") behaves exactly as isCanonical(qname) should. So use the first to implement the latter.
PowerDNS · Dec 18, 2024 · a878c70 · a878c70
1 parent ae6d458
commit a878c70
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/pdns/misc.hh b/pdns/misc.hh
@@ -469,9 +469,7 @@ pair<string, string> splitField(const string& inp, char sepa);
 
 inline bool isCanonical(const string& qname)
 {
-  if(qname.empty())
-    return false;
-  return qname[qname.size()-1]=='.';
+  return boost::ends_with(qname, ".");
 }
 
 inline DNSName toCanonic(const DNSName& zone, const string& qname)