Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(flags): tweak boolean flag usage table response values #27888

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

havenbarnes
Copy link
Contributor

@havenbarnes havenbarnes commented Jan 24, 2025

Problem

Context: https://posthog.slack.com/archives/C07Q2U4BH4L/p1737751112214639

Still works in both cases of true or a non-true value:

Screenshot 2025-01-24 at 1 55 52 PM

Screenshot 2025-01-24 at 1 50 34 PM

Changes

Make feature flag usage tab report same value for $feature_flag_response as the Activity tab does

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Ran locally with events as shown above

Copy link
Contributor

Size Change: 0 B

Total Size: 1.16 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.16 MB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants