Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(devex): minimal nx setup #27780

Draft
wants to merge 24 commits into
base: master
Choose a base branch
from
Draft

feat(devex): minimal nx setup #27780

wants to merge 24 commits into from

Conversation

mariusandra
Copy link
Collaborator

@mariusandra mariusandra commented Jan 22, 2025

Problem

Let's try getting a simpler version of #27595 in first

Changes

  • Adds nx and hooks it into two projects: frontend and hogvm-ts.
  • Now npm run build under the project root will 1) first build hogvm-ts, and 2) only then build the frontend project
  • If nothing had changed for hogvm-ts, it's cached. Same for frontend:

First run:

2025-01-22 15 21 41

Second run:

2025-01-22 15 23 34

How did you test this code?

Locally and in CI.

Copy link
Contributor

github-actions bot commented Jan 22, 2025

Size Change: 0 B

Total Size: 1.16 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.16 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants