chore: clean up surveys flags #27410
Merged
+95
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
commented
Jan 9, 2025
frontend/src/lib/constants.tsx
Outdated
| SURVEYS_ACTIONS: 'surveys-actions', // owner: #team-feature-success | ||
| SURVEYS_RECURRING: 'surveys-recurring', // owner: #team-feature-success | ||
| SURVEYS_ADAPTIVE_COLLECTION: 'surveys-recurring', // owner: #team-feature-success | ||
| SURVEYS_ADAPTIVE_LIMITS: 'surveys-adaptive-limits', // owner: #team-surveys (disabled) |
marandaneto
commented
Jan 9, 2025
frontend/src/lib/constants.tsx
Outdated
| SURVEYS_RECURRING: 'surveys-recurring', // owner: #team-feature-success | ||
| SURVEYS_ADAPTIVE_COLLECTION: 'surveys-recurring', // owner: #team-feature-success | ||
| SURVEYS_ADAPTIVE_LIMITS: 'surveys-adaptive-limits', // owner: #team-surveys (disabled) | ||
| SURVEYS_ACTIONS: 'surveys-actions', // owner: #team-surveys (enabled to team 2) |
marandaneto
commented
Jan 9, 2025
frontend/src/lib/constants.tsx
Outdated
| @@ -216,7 +212,7 @@ export const FEATURE_FLAGS = { | |||
| MESSAGING: 'messaging', // owner @mariusandra #team-cdp | |||
| BILLING_TRIAL_FLOW: 'billing-trial-flow', // owner: @zach | |||
| EDIT_DWH_SOURCE_CONFIG: 'edit_dwh_source_config', // owner: @Gilbert09 #team-data-warehouse | |||
| AI_SURVEY_RESPONSE_SUMMARY: 'ai-survey-response-summary', // owner: @pauldambra | |||
| AI_SURVEY_RESPONSE_SUMMARY: 'ai-survey-response-summary', // owner: #team-surveys (early access) | |||
There was a problem hiding this comment.
enabled and early access
marandaneto
commented
Jan 9, 2025
Comment on lines
-169
to
-171
| SURVEYS_EVENTS: 'surveys-events', // owner: #team-feature-success | ||
| SURVEYS_ACTIONS: 'surveys-actions', // owner: #team-feature-success | ||
| SURVEYS_RECURRING: 'surveys-recurring', // owner: #team-feature-success |
There was a problem hiding this comment.
those are enabled and stale already
marandaneto
commented
Jan 9, 2025
| SURVEYS_EVENTS: 'surveys-events', // owner: #team-feature-success | ||
| SURVEYS_ACTIONS: 'surveys-actions', // owner: #team-feature-success | ||
| SURVEYS_RECURRING: 'surveys-recurring', // owner: #team-feature-success | ||
| SURVEYS_ADAPTIVE_COLLECTION: 'surveys-recurring', // owner: #team-feature-success |
There was a problem hiding this comment.
not used and the value was dupe anyway
|
Size Change: -397 B (-0.04%) Total Size: 1.11 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
ioannisj
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
clean up old flags
i will remove them if PR is approved
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?