feat: add a list of default playlists to session replay #27371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 8, 2025 17:47
The idea is to show as much value a possible for users when onboard / create new dashboard
[+] added to the team as it called on both - creation of the account and the new project [*] moved the templates to helpers
pauldambra
reviewed
Jan 10, 2025
| "filter_group": {"type": "AND", "values": [{"type": "AND", "values": []}]}, | ||
| "filter_test_accounts": "true", | ||
| }, | ||
| "description": "All session recordings longer than 1 minute", |
There was a problem hiding this comment.
description and filter don't match... do we want to change the description or the query?
pauldambra
reviewed
Jan 10, 2025
Comment on lines
+92
to
+93
| {"key": "level", "type": "log_entry", "value": ["error"], "operator": "exact"}, | ||
| {"key": "message", "type": "log_entry", "value": "5", "operator": "gt"}, |
There was a problem hiding this comment.
i wonder if this is really "has more than 5 log entries and at least one is an error"
but I didn't check and more than good enough to get started with!
pauldambra
approved these changes
Jan 10, 2025
|
We do limit it to 5 playlists on free plans! You'll need to update the check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to show as much value a possible for users when onboard / create new dashboard## Problem
At the moment we have 2 main groups of users:
By “low”/”high traffic we mean ability to watch all recordings for the day (24h) within reasonable time, e.g. 30-60 mins.
Changes
How did you test this code?
Create a new account and set Session Replay during the onboarding process
1.1. Click on Session Replay
1.2. Click on Playlists
Create a new project
2.1. Click on Session Replay
2.2. Click on Playlists