-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cdp): Error tracking notifications #27072
base: master
Are you sure you want to change the base?
Conversation
# Conflicts: # posthog/migrations/max_migration.txt
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
# Conflicts: # frontend/src/lib/constants.tsx # posthog/migrations/max_migration.txt
# Conflicts: # frontend/__snapshots__/scenes-app-insights--funnel-top-to-bottom-breakdown-edit--dark.png # frontend/__snapshots__/scenes-app-insights--funnel-top-to-bottom-edit--dark.png
# Conflicts: # posthog/migrations/max_migration.txt
# Conflicts: # posthog/migrations/0535_alter_hogfunction_type.py
Size Change: +96 B (+0.01%) Total Size: 1.11 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
# Conflicts: # frontend/src/layout/navigation-3000/sidepanel/panels/activity/SidePanelActivitySubscriptions.tsx # frontend/src/scenes/pipeline/hogfunctions/filters/HogFunctionFiltersInternal.tsx # frontend/src/types.ts
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
# Conflicts: # frontend/src/scenes/error-tracking/ErrorTrackingIssueScene.tsx # frontend/src/scenes/error-tracking/ErrorTrackingScene.tsx # frontend/src/scenes/error-tracking/errorTrackingIssueSceneLogic.ts
@benjackwhite conscious you have a bunch of stuff on so no rush here but just letting you know that I rebased this against master and removed a lot of the scene based changes that were also included. Hopefully it's clearer for you to see what else needs doing to get it over the line |
Problem
Supersedes #26987
Builds on top of the internal cdp stream to add error support (UI-wise)
Changes
Follow up
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?