Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdp): Error tracking notifications #27072

Draft
wants to merge 75 commits into
base: master
Choose a base branch
from

Conversation

benjackwhite
Copy link
Contributor

@benjackwhite benjackwhite commented Dec 19, 2024

Problem

Supersedes #26987

Builds on top of the internal cdp stream to add error support (UI-wise)

Changes

  • Change the way hog function scenes are rendered so that it no longer cares what scene it is in (derives it from the props instead
  • Adds new error tracking style destinations
  • Modifies hog functions to be able to specify
  • Adds an "notifications" area so that you can see all internal destinations (feels like the best naming)
  • Adds an "inline" hog functions to the list so that we can quickly create destinations
  • Pulls from the schema (currently manually built) for example objects when configuring destinations

Follow up

  • Would be great to send have emails as a destination for this too...

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

  • chromium: 0 added, 3 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

github-actions bot and others added 10 commits December 19, 2024 18:42
# Conflicts:
#	frontend/src/lib/constants.tsx
#	posthog/migrations/max_migration.txt
# Conflicts:
#	frontend/__snapshots__/scenes-app-insights--funnel-top-to-bottom-breakdown-edit--dark.png
#	frontend/__snapshots__/scenes-app-insights--funnel-top-to-bottom-edit--dark.png
# Conflicts:
#	posthog/migrations/max_migration.txt
# Conflicts:
#	posthog/migrations/0535_alter_hogfunction_type.py
Copy link
Contributor

github-actions bot commented Dec 20, 2024

Size Change: +96 B (+0.01%)

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.11 MB +96 B (+0.01%)

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Base automatically changed from feat/cdp-internal-events to master December 27, 2024 09:03
# Conflicts:
#	frontend/src/layout/navigation-3000/sidepanel/panels/activity/SidePanelActivitySubscriptions.tsx
#	frontend/src/scenes/pipeline/hogfunctions/filters/HogFunctionFiltersInternal.tsx
#	frontend/src/types.ts
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

# Conflicts:
#	frontend/src/scenes/error-tracking/ErrorTrackingIssueScene.tsx
#	frontend/src/scenes/error-tracking/ErrorTrackingScene.tsx
#	frontend/src/scenes/error-tracking/errorTrackingIssueSceneLogic.ts
@posthog-bot posthog-bot removed the stale label Jan 13, 2025
@daibhin
Copy link
Contributor

daibhin commented Jan 21, 2025

@benjackwhite conscious you have a bunch of stuff on so no rush here but just letting you know that I rebased this against master and removed a lot of the scene based changes that were also included. Hopefully it's clearer for you to see what else needs doing to get it over the line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants