Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose rust capture in docker stack #27008

Closed

Conversation

pauldambra
Copy link
Member

Django in some setups (e.g. local dev) is trying to redirect event traffic to rust capture

let's let that work

@@ -129,6 +129,8 @@ services:
extends:
file: docker-compose.base.yml
service: capture
ports:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't follow this PR tbh. The caddy stuff already takes care of all of this without exposing ports. I can't find any path that would send it to port 3000?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not to mention this will clash with a bunch of other services so I think this doesn't solve what you think it does

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fixes localhost:8000 for me with no clashes

because of this line

urlpatterns.append(re_path(r"(?P<path>^i/.*)", ProxyView.as_view(upstream="http://localhost:3000")))

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you use localhost:8000 (which is still the default) then you're not hitting caddy, no?

@pauldambra
Copy link
Member Author

we're not doing this

@pauldambra pauldambra closed this Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants