fix: user paths url selector search #23872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anirudhpillai
changed the title
thmsobrmlr
approved these changes
Jul 22, 2024
skoob13
approved these changes
Jul 22, 2024
skoob13
pushed a commit
that referenced
this pull request
Jul 22, 2024
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
silentninja
pushed a commit
to silentninja/posthog
that referenced
this pull request
Aug 8, 2024
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #23870
Current search query has a
limit 10clause and returns randomly ordered results which means users can't always get the url they're searching for. Eg while searching for this URL, the exact URL I'm trying to match, doesn't come upSee here for example of issue
https://posthog.slack.com/archives/C0368RPHLQH/p1721472155417729?thread_ts=1721434937.496499&cid=C0368RPHLQH
Changes
Added ordering the returned results.
Also just reading docs it seems like we're going to be moving away from the
/events/endpoint, but this was a quick fix for the high priority bug, can move to/queryendpoint eventually, which will require a slight refactor in thetaxonomicFilterLogic👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
N/A
How did you test this code?
Tested on UI