Skip to content

Commit

Permalink
fix(batch-exports): Fix missing key in S3 complete multipart upload (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
rossgray authored Jan 6, 2025
1 parent 85ff197 commit e7b412b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions posthog/temporal/batch_exports/s3_batch_export.py
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ def continue_from_state(self, state: S3MultiPartUploadState):

return self.upload_id

async def complete(self) -> str:
async def complete(self) -> str | None:
if self.is_upload_in_progress() is False:
raise NoUploadInProgressError()

Expand All @@ -343,7 +343,7 @@ async def complete(self) -> str:
self.upload_id = None
self.parts = []

return response["Location"]
return response.get("Key")

async def abort(self):
"""Abort this S3 multi-part upload."""
Expand Down

0 comments on commit e7b412b

Please sign in to comment.