Skip to content

Commit

Permalink
remove tests reliant on legacy people_urls
Browse files Browse the repository at this point in the history
  • Loading branch information
thmsobrmlr committed Jan 10, 2025
1 parent df9a116 commit d3b104a
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 382 deletions.
4 changes: 2 additions & 2 deletions posthog/api/insight.py
Original file line number Diff line number Diff line change
Expand Up @@ -1117,7 +1117,7 @@ def funnel(self, request: request.Request, *args: Any, **kwargs: Any) -> Respons

return Response(funnel)

@cached_by_filters
# @cached_by_filters
def calculate_funnel(self, request: request.Request) -> dict[str, Any]:
team = self.team
filter = Filter(request=request, data={"insight": INSIGHT_FUNNELS}, team=self.team)
Expand All @@ -1139,7 +1139,7 @@ def calculate_funnel(self, request: request.Request) -> dict[str, Any]:
"timezone": team.timezone,
}

@cached_by_filters
# @cached_by_filters
def calculate_funnel_hogql(self, request: request.Request) -> dict[str, Any]:
team = self.team
filter = Filter(request=request, team=team)
Expand Down
1 change: 1 addition & 0 deletions posthog/api/test/test_insight.py
Original file line number Diff line number Diff line change
Expand Up @@ -3055,6 +3055,7 @@ def test_insight_funnels_hogql_local_filters(self) -> None:

@snapshot_clickhouse_queries
@also_test_with_materialized_columns(event_properties=["int_value"], person_properties=["fish"])
@override_settings(PERSON_ON_EVENTS_OVERRIDE=False, PERSON_ON_EVENTS_V2_OVERRIDE=False)
def test_insight_funnels_hogql_breakdown(self) -> None:
with freeze_time("2012-01-15T04:01:34.000Z"):
_create_person(
Expand Down
Loading

0 comments on commit d3b104a

Please sign in to comment.