fix(propdefs): fix group-type caching (#24928)

PostHog · Sep 12, 2024 · 9580ac6 · 9580ac6
1 parent e6a76ee
commit 9580ac6
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/rust/property-defs-rs/src/app_context.rs b/rust/property-defs-rs/src/app_context.rs
@@ -20,7 +20,7 @@ pub struct AppContext {
     pub cache_warming_cutoff: f64,
     pub skip_writes: bool,
     pub skip_reads: bool,
-    pub group_type_cache: Cache<String, i32>,
+    pub group_type_cache: Cache<String, i32>, // Keyed on group-type name, and team id
 }
 
 impl AppContext {
@@ -96,7 +96,9 @@ impl AppContext {
                 continue;
             };
 
-            let cached = self.group_type_cache.get(name);
+            let name = format!("{}:{}", update.team_id, name);
+
+            let cached = self.group_type_cache.get(&name);
             if let Some(index) = cached {
                 update.group_type_index =
                     update.group_type_index.take().map(|gti| gti.resolve(index));
@@ -114,7 +116,7 @@ impl AppContext {
                 .await?;
 
             if let Some(index) = found {
-                self.group_type_cache.insert(name.to_string(), index);
+                self.group_type_cache.insert(name, index);
                 update.group_type_index =
                     update.group_type_index.take().map(|gti| gti.resolve(index));
             } else {