[IMPORT] add modal on edit import action #3343
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andriacap
changed the title
andriacap
force-pushed
the
feat/add-warning-on-event-import
branch
from
6015f92 to
2626535
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/import-monitorings #3343 +/- ##
===========================================================
- Coverage 84.03% 84.01% -0.03%
===========================================================
Files 122 122
Lines 9742 9742
===========================================================
- Hits 8187 8185 -2
- Misses 1555 1557 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andriacap
force-pushed
the
feat/add-warning-on-event-import
branch
from
2626535 to
071cd0f
Compare
- create modal action component - call modal on edit import and next button step - add model modalData - remove deleteModal (replace by new component) [Refs]: https://github.com/orgs/PnX-SI/projects/13?pane=issue&itemId=82942301 Reviewed-by: andriacap
- Add method and accessor get to check if import is completed - Replace code where checking if import is completed Reviewed-by: andriacap
andriacap
force-pushed
the
feat/add-warning-on-event-import
branch
from
071cd0f to
737412a
Compare
edelclaux
force-pushed
the
feat/add-warning-on-event-import
branch
from
5a2947c to
ec13e57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
feat: add modal for edit import action
refact: add logic to check if import is done
Task project import