Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove camelCase properties from SFM #1440

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Remove camelCase properties from SFM #1440

wants to merge 4 commits into from

Conversation

chraibi
Copy link
Contributor

@chraibi chraibi commented Jan 19, 2025 •
edited
Loading

This PR addresses issue #1415.

  • Introduce new properties.
  • Mark existing camelCase properties as deprecated with appropriate warnings
  • Verify the functionality of the new snake_case properties.
  • Test deprecated camelCase properties to ensure they still work and raise deprecation warnings.
  • Ensure consistency between the old and new properties (changes to one are reflected in the other).
  • Include a Ruff check to enforce snake_case naming patterns while explicitly ignoring violations for deprecated camelCase properties.
  • Rename v0 in all models to desired_speed

@chraibi chraibi changed the title Add tests for deprecated camelCase properties of SFM Remove camelCase properties from SFM Jan 19, 2025
@Ozaq Ozaq added this to the v1.3.0 milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@chraibi @Ozaq