-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
akit to main #299
akit to main #299
Conversation
after thinking i think this implementation of adv kit works best for terry, where we ignore the separate hardware implementations for real and sim but rather combine the single implementation with the subsystem control logic. its wacky but comparing out ampper code with 6328 code should make it make sense. also not final :P
…a be so small every time but might as well distinguish the actual inputs ig
I love these commit messages 😂 they are beautiful ❤️ |
someone understood the assignment |
A couple notes before this gets merged, however... |
I 100% agree with Alex here. For something that is this big of a change it should go through multiple reviewers, or at least be able to be easily backed up in case of something terrible. I also recommend that all assigned reviewers review the code ASAP. 1. To get familiar with the changes. And 2. To double check multiple times over. At the end of that, then asking for mine or Alex's final review, of which if there is another major change, the process should repeat. I know it sounds tedious, but I highly recommend it for something this big and new. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reading through every single line of code very in depth and completely and absolutely locking in for hours upon hours, I have determine that this is // working
Thank you Zachary Good |
Thank you Clint Cushman |
This reverts commit 3022525.
for the past month akit has basically been main so lets seal the deal