-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setpoint generator #288
base: main
Are you sure you want to change the base?
Setpoint generator #288
Conversation
…functional (removed import to add this comment quickly)
(now its time to implement and probably clean up some more)
….. again comment out discretize and check for satisfying constraints (still problem with rotating and moving???)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's like you bring a stench of autoformatting everywhere you go... I'm sure the math works at least. How do you think we can find a way to calculate the numbers required for these kinematics?
protected final static SwerveKinematicLimits KINEMATIC_LIMITS = new SwerveKinematicLimits(); | ||
static { | ||
KINEMATIC_LIMITS.MAX_DRIVE_VELOCITY = AutoConstants.MAX_SPEED_METERS_PER_SECOND; // m/s | ||
KINEMATIC_LIMITS.MAX_DRIVE_ACCELERATION = 30.0; // m/s^2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to be tuned, but i have no idea what it should be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.. I don't know how we might calculate that, I'll try to do some more research later...
src/main/java/frc/robot/util/custom/geometry/CustomTwist2d.java
Outdated
Show resolved
Hide resolved
While you can use these comments to improve this pr, would you be okay if it was closed due to worlds being so soon and this not showing itself as a huge priority since our autos aren't bad by any means...? |
Sounds fair enough, I'm quite sad this wont end up being used for anything this year, but hey! At least it cool! It will also lead to some better implementation next year if the team goes to advantage kit |
...i cant believe i forgot
I am going to turn this into a draft, as this PR will never see the light of day, until next year... (maybe) |
No description provided.