Eslint Refactor #46
Merged
Eslint Refactor #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import {GraphQLString} from 'graphql'; | ||
| import {CachedUser} from './cachedUserSchema'; | ||
| import {getUserByUserId} from './helpers'; | ||
| // import {getUserByUserId} from './helpers'; |
There was a problem hiding this comment.
Did you comment this out because it's unused below?
There was a problem hiding this comment.
I favored commenting out unused imports because they were generally auth related (not just in this case), and I figured they could have been added for future use - also related to the TODO below.
It also conformed to some other commented out auth related stuff.
| @@ -3,8 +3,8 @@ import {push} from 'react-router-redux'; | |||
| import {localStorageVars} from '../../utils/clientOptions'; | |||
|
|
|||
| let key; | |||
| export default ComposedComponent => { | |||
| return class RequiredAuth extends Component { | |||
| export default ComposedComponent => | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Largely the same as the first 'linting' pull request.
A (relatively) major refactor making our source ESLint compliant based on our custom rule set (derived mainly from airbnb's rules).
Things done:
⛵