Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support to pass ROBOT_INITIAL_POSE via argument, in addition to environment #147

Open
wants to merge 1 commit into
base: kinetic-devel
Choose a base branch
from

Conversation

k-okada
Copy link
Contributor

@k-okada k-okada commented May 22, 2020

this allow user to write

    <include file="$(find pr2_gazebo)/launch/pr2_empty_world.launch">
	<arg name="world_name" value="$(arg world_name)" />
	<arg name="ROBOT_INITIAL_POSE" value="-x 0.75 -y 0 -z 0" />
    </include>

and it will not break current usage:

ROBOT_INITIAL_POSE="-x 0.75 -y 0 -z 0" roslaunch pr2_gazebo pr2_empty_world.lauch

k-okada added a commit to k-okada/jsk_demos that referenced this pull request May 22, 2020
@k-okada k-okada force-pushed the arg_robot_initial_pose branch from 048a4cd to 3cda008 Compare May 22, 2020 10:39
@k-okada k-okada force-pushed the arg_robot_initial_pose branch from 3cda008 to 557b61d Compare May 22, 2020 10:39
k-okada added a commit to k-okada/jsk_demos that referenced this pull request May 23, 2020
Copy link
Member

@v4hn v4hn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this really work?

pr2.launch uses pass_all_args, but the documentation of this argument (I'd never heard of it before) makes it sound like pr2.launch should at least define the argument and only forwarding it in <include> can be omitted. Otherwise launch file sanitizers will have a harder time figuring out whether arguments are actually used..

If that's just a misunderstanding on my end, feel free to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants