Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match error disorder #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

multimeric
Copy link

This fixes the error that has a message like this:

ERROR//13:26:29.697//OpenBabel OBAtom with serial number 8859 could not be matched to a BioPython counterpart.
Traceback (most recent call last):
  File "/home/migwell/miniconda3/envs/arpeggio/lib/python3.7/site-packages/arpeggio/core/interactions.py", line 1996, in _establish_structure_mappping
    biopython_atom = serial_to_bio[serial]
KeyError: 8859

This happens because the protein_reader module treats ? in the label_alt_id as though the atom has an alternate atom, and therefore is disordered, which ultimately messes up the ID mapping. However I believe that it's much better to treat ? as though it is not disordered, and indeed if I do this, it fixes run errors that I encounter. Notably this is not a duplicate of #4, which has the same exception class, but is related to the fact that PDB input is broken. This error happens with .mmcif files instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant