Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the error that has a message like this:
This happens because the
protein_reader
module treats?
in thelabel_alt_id
as though the atom has an alternate atom, and therefore is disordered, which ultimately messes up the ID mapping. However I believe that it's much better to treat?
as though it is not disordered, and indeed if I do this, it fixes run errors that I encounter. Notably this is not a duplicate of #4, which has the same exception class, but is related to the fact that PDB input is broken. This error happens with .mmcif files instead.