-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GS/HW: Implement RT in RT support #11461
base: master
Are you sure you want to change the base?
Conversation
73707eb
to
f6410bd
Compare
f6410bd
to
0959a98
Compare
0959a98
to
66de280
Compare
a419eee
to
f6f1761
Compare
f6f1761
to
b179c6d
Compare
Fixes #11417. |
Fixes #10982 |
52e7712
to
afc0c25
Compare
Fixes #1339 (comment) |
Thanks for checking, I actually have a preliminary "fixes" list, which is as follows
|
5317ebd
to
52586f0
Compare
Yes, already got it fixed locally, just not pushed it yet :) |
4e3a766
to
b1971c4
Compare
Okay fix for Tomb Raider (and others when upscaling) should be okay now. |
8254db0
to
c952f9d
Compare
I think this is now at a point where it can be tested properly. Man that was a nightmare. Try everything you can, as there was a lot of changes to behaviour to try and compensate for other things working properly now or doing more things than they used to do, so any regressions will need to be dealt with. |
06907b8
to
8ca7b77
Compare
- Channel shuffles now check how many pages require drawing before doing the shuffle. - Split texture shuffles don't create new targets with bad valid areas.
3bd492f
to
73ef4e7
Compare
- this should be okay/limited to certain situations like Battlefield 2. Scissor isn't 100% guaranteed to be right, but it's probably better than nothing.
73ef4e7
to
b372cd9
Compare
Just added some Tex in RT fixes for behaviour that's used in Ridge Racer V. Turns out the PR made the lights for the street lamps and cars worse with the new changes, however it never worked in master before, either, but did give rainbow garbage on occasion. This is now accurate to Software mode |
Fixes #11965 |
Fixes #9888 |
Description of Changes
Adds support for render target inside render target draws and shuffles, where games point to an offset inside a previously drawn target, usually to update single pages, or offset half way through a picture.
Rationale behind Changes
We didn't support this and relied on exact start address matches, and a bunch of games do it.
Suggested Testing Steps
Test games which had "top left corner" bugs or weird half screen problems.
Known to fix:
Battlefield 2 - Fixes things the CRC hack was chopping out, also required fixing how sources get invalidated
Big Mutha Truckers - No longer requires a CRC hack for half screen shuffle
Call of Duty - World at War - Final Fronts - lighting closer matches software
Death by Degrees - lighting and fog effects post processing (top left corner) are fixed (CRC can be removed)
Drakengard - Post shuffle effect on death
Driv3r - Doesn't need such a cacophony of fixes, just CSBW 4/2 + Tex in RT
Haunting Ground - Quite possibly no longer needs CRC hack
Hitman Blood Money - Post processing and shadows fixed (still needs CRC for weird corner uploading thing, but may be more fixable these days)
Hitman Contracts - Graphics completely fixed
Ghost in the Shell - Stand Alone Complex - No longer requires CRC hack and fixes channel shuffle
Jak X - Combat Racing - Player 2 now visible
Peter Jackson's King Kong- The Official Game of the Movie - pretty much fixed with rt in rt
Manhunt 2 - Post Process (top left corner) lighting fixed
Onimusha - Warlords - fmvs seem to not flicker (game currently uses SW FMV)
Ridge Racer V - Less hacks required, intro can now be upscaled
Sniper Elite - Second player lighting overlay fixed
Stolen - All graphics processing is fixed, lighting, etc. Speed is also not terrible
Spiderwick Chronicles - Half screen problem in book fixed
Suikoden III - Half screen black and white effect fixed
SWAT - Global Strike Team - Player 2 colours corrected
Taiko no Tatsujin Bang Tap - Lighting overlay (top left corner) fixed
Tekken 5 - Fire effect can now be used upscaled and half screen fire effect problem is fixed
TOCA Race Driver 2 - shadows fixed
Time Crisis 3 - Post processing looks correct now
Tomb Raider - Legends - Fixes for post lighting effects not covering the screen in some levels and goggles
Wild Arms 5 - No longer requires Framebuffer Conversion hack ,meaning sepia scenes now upscale properly
Wrath Unleashed - Fixes colours
WRC 3 - Half screen fog effect fixed.
Improves but doesn't currently fix:
Pachipara
Raw Danger
Steambot Chronicles
Note: This is gated behind Tex in RT and will break some games if left on, be it on your own head!
Fixes #11417 - Battlefield 2
Fixes #11416 - Battlefield 2
Fixes #8869 - Battlefield 2
Fixes #11085 - Death by Degrees
Fixes #3855 - Drakengard
Fixes #10399 - Hitman - Contracts
Fixes #4251 - Hitman - Blood Money
Fixes #12215 - Jak green sage's eyes
Fixes #4964 - Jak X - Combat Racing
Fixes #11870 - King Kong
Fixes #10164 - Manhunt 2
Fixes #8574 - Ridge Racer V coloured light problem
Fixes #8328 - Stolen
Fixes #3849 - Suikoden 3
Fixes #10471 - SWAT Global Strike Team
Fixes #8995 - Tekken 5
Fixes #7942 - Time Crisis 3
Fixes #913 - TOCA Race Driver 2
Fixes #267 - Wrath Unleashed
Fixes #10982 - WRC 3